misskey icon indicating copy to clipboard operation
misskey copied to clipboard

fix: Bump sharp to 0.33.2

Open tamaina opened this issue 1 year ago • 2 comments

Fix https://github.com/misskey-dev/misskey/issues/13383

What

  • sharp.jsのバージョンを上げる
  • ついでにblurhashの生成をico/bmpにも対応させる

Why

Maybe fix https://github.com/misskey-dev/misskey/issues/13383

Additional info (optional)

Checklist

  • [ ] Read the contribution guide
  • [ ] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [ ] (If needed) Update CHANGELOG.md
  • [ ] (If possible) Add tests

tamaina avatar Feb 18 '24 15:02 tamaina

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

github-actions[bot] avatar Feb 18 '24 15:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f8261a1) 79.95% compared to head (51863e3) 64.48%. Report is 365 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13391       +/-   ##
============================================
- Coverage    79.95%   64.48%   -15.48%     
============================================
  Files          956      981       +25     
  Lines       108864   110006     +1142     
  Branches      8413     5605     -2808     
============================================
- Hits         87045    70940    -16105     
- Misses       21819    37632    +15813     
- Partials         0     1434     +1434     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 18 '24 15:02 codecov[bot]

なんかChromaticに嫌われている

tamaina avatar Feb 19 '24 12:02 tamaina

🙏

syuilo avatar Feb 21 '24 05:02 syuilo