misskey icon indicating copy to clipboard operation
misskey copied to clipboard

enhance: 通知の履歴をリセットできるように

Open kakkokari-gtyih opened this issue 1 year ago • 2 comments

What

各ユーザーごとに通知の履歴を手動でリセットできるように

Why

Fix #13317

Additional info (optional)

Checklist

  • [x] Read the contribution guide
  • [ ] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [x] (If needed) Update CHANGELOG.md
  • [ ] (If possible) Add tests

kakkokari-gtyih avatar Feb 16 '24 09:02 kakkokari-gtyih

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -58865,6 +58865,135 @@
         }
       }
     },
+    "/notifications/flush": {
+      "post": {
+        "operationId": "notifications/flush",
+        "summary": "notifications/flush",
+        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *write:notifications*",
+        "externalDocs": {
+          "description": "Source code",
+          "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/notifications/flush.ts"
+        },
+        "tags": [
+          "notifications"
+        ],
+        "security": [
+          {
+            "bearerAuth": []
+          }
+        ],
+        "responses": {
+          "204": {
+            "description": "OK (without any results)"
+          },
+          "400": {
+            "description": "Client error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "INVALID_PARAM": {
+                    "value": {
+                      "error": {
+                        "message": "Invalid param.",
+                        "code": "INVALID_PARAM",
+                        "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "401": {
+            "description": "Authentication error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "CREDENTIAL_REQUIRED": {
+                    "value": {
+                      "error": {
+                        "message": "Credential required.",
+                        "code": "CREDENTIAL_REQUIRED",
+                        "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "403": {
+            "description": "Forbidden error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "AUTHENTICATION_FAILED": {
+                    "value": {
+                      "error": {
+                        "message": "Authentication failed. Please ensure your token is correct.",
+                        "code": "AUTHENTICATION_FAILED",
+                        "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "418": {
+            "description": "I'm Ai",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "I_AM_AI": {
+                    "value": {
+                      "error": {
+                        "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
+                        "code": "I_AM_AI",
+                        "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          },
+          "500": {
+            "description": "Internal server error",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Error"
+                },
+                "examples": {
+                  "INTERNAL_ERROR": {
+                    "value": {
+                      "error": {
+                        "message": "Internal error occurred. Please contact us if the error persists.",
+                        "code": "INTERNAL_ERROR",
+                        "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    },
     "/notifications/mark-all-as-read": {
       "post": {
         "operationId": "notifications/mark-all-as-read",

Get diff files from Workflow Page

github-actions[bot] avatar Feb 16 '24 09:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 75.40984% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 66.05%. Comparing base (ec18991) to head (416f0cc).

:exclamation: Current head 416f0cc differs from pull request most recent head dd9a114. Consider uploading reports for the commit dd9a114 to get more accurate results

Files Patch % Lines
...nd/src/server/api/endpoints/notifications/flush.ts 75.75% 8 Missing :warning:
packages/backend/src/core/NotificationService.ts 22.22% 7 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13335      +/-   ##
===========================================
+ Coverage    64.65%   66.05%   +1.39%     
===========================================
  Files          985      990       +5     
  Lines       110587   115259    +4672     
  Branches      5625     4386    -1239     
===========================================
+ Hits         71505    76134    +4629     
- Misses       37649    39093    +1444     
+ Partials      1433       32    -1401     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 09:02 codecov[bot]

(とりあえずこいつはChangelog位置変更・review対応をやったのでマージできるようにしときました)

kakkokari-gtyih avatar Feb 19 '24 09:02 kakkokari-gtyih

BackspaceKeyで導入され問題なく動作していることを確認

kakkokari-gtyih avatar Feb 20 '24 06:02 kakkokari-gtyih

👍🏻

syuilo avatar Feb 29 '24 11:02 syuilo