misskey icon indicating copy to clipboard operation
misskey copied to clipboard

feat: プレイにAPI Tokenを要求できる関数を追加

Open chocolate-pie opened this issue 1 year ago • 6 comments

What

プレイにAPIトークンを要求できる関数を追加しました

https://github.com/misskey-dev/misskey/assets/106949016/a9be0a11-6009-4685-826d-bf3d9696161e

Why

プレイからAPI Tokenを要求できる関数があった方が便利なため

Additional info (optional)

Checklist

  • [x] Read the contribution guide
  • [ ] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [x] (If needed) Update CHANGELOG.md
  • [ ] (If possible) Add tests

chocolate-pie avatar Jun 04 '23 23:06 chocolate-pie

Codecov Report

Merging #10949 (e4e8e70) into develop (7097d55) will increase coverage by 0.08%. The diff coverage is 80.00%.

:exclamation: Current head e4e8e70 differs from pull request most recent head e987077. Consider uploading reports for the commit e987077 to get more accurate results

@@             Coverage Diff             @@
##           develop   #10949      +/-   ##
===========================================
+ Coverage    77.68%   77.77%   +0.08%     
===========================================
  Files          919      911       -8     
  Lines        92635    91912     -723     
  Branches      7749     7757       +8     
===========================================
- Hits         71967    71488     -479     
+ Misses       20668    20424     -244     
Impacted Files Coverage Δ
packages/backend/src/misc/flash-token.ts 0.00% <0.00%> (ø)
...kages/backend/src/server/api/endpoints/app/show.ts 76.27% <50.00%> (ø)
packages/backend/src/server/api/ApiCallService.ts 74.44% <68.75%> (-0.62%) :arrow_down:
...ages/backend/src/server/api/AuthenticateService.ts 76.92% <75.00%> (+0.39%) :arrow_up:
...ackend/src/server/api/endpoints/flash/gen-token.ts 83.92% <83.92%> (ø)
packages/backend/src/core/CacheService.ts 100.00% <100.00%> (+4.10%) :arrow_up:
packages/backend/src/server/api/EndpointsModule.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/endpoint-base.ts 94.28% <100.00%> (+0.08%) :arrow_up:
packages/backend/src/server/api/endpoints.ts 100.00% <100.00%> (ø)
...end/src/server/api/endpoints/drive/files/create.ts 91.20% <100.00%> (ø)
... and 5 more

... and 103 files with indirect coverage changes

codecov[bot] avatar Jun 04 '23 23:06 codecov[bot]

Playの翻訳は「プレイ」ではなく「Play」のままでいいはず

image

kakkokari-gtyih avatar Jun 05 '23 11:06 kakkokari-gtyih

@kakkokari-gtyih 直しました。

chocolate-pie avatar Jun 05 '23 22:06 chocolate-pie

@syuilo 失礼ですが、このプルリクエストをマージする予定はありますか?無ければ閉じますけど

chocolate-pie avatar Jul 10 '23 02:07 chocolate-pie

ないんじゃない

tamaina avatar Jul 10 '23 02:07 tamaina

@syuilo 失礼ですが、このプルリクエストをマージする予定はありますか?無ければ閉じますけど

まだ見れてないのでなんとも言えません🙏

syuilo avatar Jul 10 '23 05:07 syuilo