misskey icon indicating copy to clipboard operation
misskey copied to clipboard

Release: 13.9.2

Open syuilo opened this issue 1 year ago • 6 comments

syuilo avatar Mar 05 '23 11:03 syuilo

Codecov Report

Merging #10218 (5ccbeda) into master (7e87005) will increase coverage by 0.09%. The diff coverage is 64.28%.

:exclamation: Current head 5ccbeda differs from pull request most recent head 31f9ea3. Consider uploading reports for the commit 31f9ea3 to get more accurate results

@@            Coverage Diff             @@
##           master   #10218      +/-   ##
==========================================
+ Coverage   69.14%   69.23%   +0.09%     
==========================================
  Files         706      707       +1     
  Lines       65312    65407      +95     
  Branches     5181     5214      +33     
==========================================
+ Hits        45159    45286     +127     
+ Misses      20153    20121      -32     
Impacted Files Coverage Δ
...kend/src/core/entities/GalleryPostEntityService.ts 51.66% <0.00%> (-0.88%) :arrow_down:
packages/backend/src/server/FileServerService.ts 19.05% <5.71%> (-0.51%) :arrow_down:
packages/backend/src/core/DriveService.ts 57.08% <52.00%> (-0.06%) :arrow_down:
...ges/backend/src/core/entities/UserEntityService.ts 91.60% <57.14%> (ø)
packages/backend/src/core/DownloadService.ts 71.62% <73.68%> (+0.08%) :arrow_up:
...ackend/src/core/entities/DriveFileEntityService.ts 71.18% <100.00%> (+2.24%) :arrow_up:
...ges/backend/src/core/entities/NoteEntityService.ts 83.25% <100.00%> (+0.88%) :arrow_up:
packages/backend/src/misc/correct-filename.ts 100.00% <100.00%> (ø)
packages/backend/src/misc/is-mime-image.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 05 '23 11:03 codecov[bot]

ふと思ったけど identicon のキー変えると生成される画像変わるのでちょっと微妙かも

rinsuki avatar Mar 05 '23 11:03 rinsuki

(せめて CHANGELOG にはその旨但し書きしておいたほうがよさそう)

rinsuki avatar Mar 05 '23 11:03 rinsuki

新しく追加されたチャンネルの投稿ボタンから投稿すると、リクエストに channelId が乗らずに普通の投稿になってしまいます image

Khsmty avatar Mar 05 '23 11:03 Khsmty

新しく追加されたチャンネルの投稿ボタンから投稿すると、リクエストに channelId が乗らずに普通の投稿になってしまいます image

👍🏻👍🏻👍🏻

直しました

syuilo avatar Mar 05 '23 11:03 syuilo

しゅいろが寝る直前にリリースを切る習慣をやめて欲しいので個人的には明日の朝Approveしたい所存

tamaina avatar Mar 05 '23 11:03 tamaina

Approveしたけどビルドが…

ci skipしたほうが良かったかもしれない

tamaina avatar Mar 06 '23 02:03 tamaina

Dockerビルド、激早になってた

tamaina avatar Mar 06 '23 02:03 tamaina

🙏🏻

syuilo avatar Mar 06 '23 02:03 syuilo