misskey icon indicating copy to clipboard operation
misskey copied to clipboard

enhance(server): downloadUrlでContent-Dispositionからファイル名を取得

Open tamaina opened this issue 2 years ago • 3 comments

Resolve #10036 Resolve #4750

  • downloadUrlでContent-Dispositionからファイル名を取得し、returnするように
  • addFileでvalidateFileNameし、拡張子はなるべく正確にする
  • オブジェクトストレージのContent-Dispositionのファイル名の拡張子をContent-Typeに添ったものにする
  • /files/でオリジナルのファイルを応答するとき、commonReadableHandlerGeneratorである必要はなさそうなので削除

tamaina avatar Feb 28 '23 17:02 tamaina

Codecov Report

Merging #10150 (d06cab1) into develop (7e87005) will increase coverage by 0.00%. The diff coverage is 50.00%.

@@           Coverage Diff            @@
##           develop   #10150   +/-   ##
========================================
  Coverage    69.14%   69.14%           
========================================
  Files          706      707    +1     
  Lines        65312    65357   +45     
  Branches      5181     5185    +4     
========================================
+ Hits         45159    45191   +32     
- Misses       20153    20166   +13     
Impacted Files Coverage Δ
packages/backend/src/server/FileServerService.ts 18.88% <3.70%> (-0.69%) :arrow_down:
packages/backend/src/core/DriveService.ts 57.08% <52.00%> (-0.06%) :arrow_down:
packages/backend/src/core/DownloadService.ts 71.62% <73.68%> (+0.08%) :arrow_up:
packages/backend/src/misc/correct-filename.ts 100.00% <100.00%> (ø)
packages/backend/src/misc/content-disposition.ts 100.00% <0.00%> (+50.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Feb 28 '23 17:02 codecov[bot]

簡単にmiscのテストを書いた

tamaina avatar Feb 28 '23 17:02 tamaina

  • コメントつけた
  • テスト多分直った

tamaina avatar Mar 03 '23 17:03 tamaina

👍🏻👍🏻

syuilo avatar Mar 04 '23 07:03 syuilo