misskey
misskey copied to clipboard
fix(server): DriveFile related N+1 query when call note packMany
Fix #10129
Codecov Report
Merging #10133 (84899eb) into develop (81e6a21) will increase coverage by
0.13%
. The diff coverage is25.75%
.
@@ Coverage Diff @@
## develop #10133 +/- ##
===========================================
+ Coverage 25.06% 25.19% +0.13%
===========================================
Files 705 706 +1
Lines 65151 65281 +130
Branches 2307 2331 +24
===========================================
+ Hits 16329 16447 +118
- Misses 48822 48834 +12
Impacted Files | Coverage Δ | |
---|---|---|
...kend/src/core/entities/GalleryPostEntityService.ts | 51.66% <0.00%> (-0.88%) |
:arrow_down: |
...ges/backend/src/core/entities/NoteEntityService.ts | 20.23% <14.28%> (-0.06%) |
:arrow_down: |
...end/src/core/entities/NotificationEntityService.ts | 46.21% <23.33%> (+11.25%) |
:arrow_up: |
...ackend/src/core/entities/DriveFileEntityService.ts | 29.22% <27.27%> (-0.33%) |
:arrow_down: |
packages/backend/src/misc/is-not-null.ts | 60.00% <60.00%> (ø) |
|
packages/backend/src/core/WebhookService.ts | 39.08% <0.00%> (-1.40%) |
:arrow_down: |
...ges/backend/src/core/entities/RoleEntityService.ts | 38.15% <0.00%> (-1.28%) |
:arrow_down: |
packages/backend/src/core/AntennaService.ts | 35.39% <0.00%> (-0.64%) |
:arrow_down: |
packages/backend/src/server/ServerService.ts | 0.00% <0.00%> (ø) |
|
packages/backend/src/server/api/stream/types.ts | 0.00% <0.00%> (ø) |
|
... and 12 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
is-not-nullでDon't use
{}as a type.
{} actually means "any non-nullish value".
が出てる
直した
🙏🙏
ファイル付きノートのRenoteをpackしたときに、場合によってはファイルが消えるわね