misskey icon indicating copy to clipboard operation
misskey copied to clipboard

timeline API only returns last 30 days

Open dakkar opened this issue 2 years ago โ€ข 7 comments

๐Ÿ’ก Summary

The notes/timeline, notes/hybrid-timeline, notes/local-timeline endpoints only return notes from the last 30 days

๐Ÿฅฐ Expected Behavior

Asking sinceId:'0' should return the oldest note that the server saw

๐Ÿคฌ Actual Behavior

Asking sinceId:'0' returns a note from a month ago, regardless of how long the instance has been running and receiving notes.

๐Ÿ“Œ Environment

Misskey version: any version after 6f51e7300e52994943fcec32aaa29693623f533b


The commit 6f51e7300e52994943fcec32aaa29693623f533b doesn't explain why it was made. I feel it's some debugging code that was released by accident, especially considering that notes/global-timeline does not share this limitation.

dakkar avatar Feb 24 '23 13:02 dakkar

The commit 6f51e7300e52994943fcec32aaa29693623f533b doesn't explain why it was made.

FYI: https://github.com/misskey-dev/misskey/issues/9205#issuecomment-1345179841

acid-chicken avatar Feb 24 '23 15:02 acid-chicken

oh, so it's intentional? why doesn't global-timeline do the same thing?

dakkar avatar Feb 24 '23 15:02 dakkar

Performance problems were occurring with Home Timeline and Local Timeline on large instances and the cause needed to be investigated. On the other hand, Global Timeline was not included in the restriction because the problem was not occurred.

Either way, the restrictions added in 6f51e7300e52994943fcec32aaa29693623f533b did not solve the performance problem, so I think now they can be removed.

acid-chicken avatar Feb 24 '23 15:02 acid-chicken

thank you for the explanation, my Japanese is not good enough to follow the discussion and automatic translation doesn't help enough!

dakkar avatar Feb 24 '23 15:02 dakkar

ใƒญใƒผใƒซใงๅค‰ๆ›ดใงใใฆใ‚‚ใ„ใ„ใ‹ใ‚‚ใ—ใ‚Œใชใ„

@syuilo

tamaina avatar Feb 27 '23 10:02 tamaina

https://github.com/misskey-dev/misskey/issues/9205#issuecomment-1368397522 ใ ใ—ไธ€ๅพ‹ใงๅทฎใ—ๆˆปใ—ใฆใ„ใ„ใ‚“ใ˜ใ‚ƒใชใ„ใฎ

acid-chicken avatar Feb 27 '23 14:02 acid-chicken

~~ใใ‚‚ใใ‚‚ใ‚คใƒณใƒ‡ใƒƒใ‚ฏใ‚น็š„ใชใ“ใจใ‚’่€ƒใˆใ‚‹ใจใใฎใธใ‚“ใฎๆ—ฅใซใกใฎidใ‚’ไฝœใฃใฆ็ตžใ‚‰ใชใ„ใจใƒ€ใƒกใฃใฝใ„~~ใฃใฆๆ€ใฃใŸใ‘ใฉใชใ‚“ใ‹ใใ‚Œใงใ‚‚ userId ใฎ index ใจใ‹ใซ id ๅ…ฅใฃใฆใชใ„ใ‹ใ‚‰ใ ใ‚ใใ†ใ ใช (idใŒPKใฎใ‚คใƒณใƒ‡ใƒƒใ‚ฏใ‚นใ‚ใ‚‹ใฎใงใชใ„ใ‚ˆใ‚Šใฏใƒžใ‚ทใใ†ใชๆฐ—ใฏใ™ใ‚‹ใŒ)

rinsuki avatar Feb 27 '23 19:02 rinsuki