emoji-mart icon indicating copy to clipboard operation
emoji-mart copied to clipboard

Published 20 hours ago • verified publisher icon missive

Typescript migration

Open zhouzi opened this issue 2 years ago • 2 comments

As suggested in #576, it would be great to have emoji-mart's types in its repository. @Scalahansolo started to work on it and had issues with parcel to generate the types (reported in https://github.com/parcel-bundler/parcel/issues/8014). I am also interested in the types so to help move forward I went ahead and investigated the issue.

I am trying to keep the configuration as minimal as possible and with 2c2c515f0bf06abbe827eea2dacfb477a8855cd2 I am able to build the library and generate the types. There is not much to generate for now but at least we got past the issue with parcel.

To be transparent, I don't know if I will have the time to migrate the whole codebase. We will probably create a declaration file on our end to move forward. I will post an update if it becomes clear that I won't be able to work on it on my spare time in the next few days, in case someone else wants to take over.

zhouzi avatar May 17 '22 10:05 zhouzi

Just wanted to check here quick and see if this is something we collectively want to tackle. The actual TS migration might take me a couple of hours to burn through and I think it would be an awesome addition.

Scalahansolo avatar Jul 20 '22 13:07 Scalahansolo

Sorry, I wasn't able to work on this and we ended up using the previous version. Feel free to give it a go 💪

zhouzi avatar Jul 20 '22 13:07 zhouzi

@jwhitham-ds in now working on this through #671 🙌

zhouzi avatar Aug 12 '22 07:08 zhouzi