mpf
mpf copied to clipboard
LightDescription missing hardware_number for VisualPinball.Engine platform
While working on dependency updates for VisualPinball.Engine.Mpf, we noticed an exception while parsing lights when a user presses Get Machine Description
.
Coils and switches currently have a number
node. Lights seem to be missing a number node:
https://github.com/missionpinball/mpf/blob/97efc55c155ac9d32d00b359f27684f8a7d47167/mpf/platforms/visual_pinball_engine/protobuf/platform.proto#L20-L35
Other examples in the repo reference number
for lights as well:
https://github.com/missionpinball/mpf/blob/56dcfb9fa17065d7acb9b4c895c272bf1d5119bd/mpf/benchmarks/machine_files/shows/config/config.yaml#L1-L11
Hello again. We are about to release a new version of VisualPinball.Engine.Mpf
.
@jabdoa2 - Any thoughts on this issue?
Sorry I missed it. I can try to add something this weekend.