Peter Johnson

Results 297 issues of Peter Johnson

Looking over the code today I noticed that the query 'Am Falkplatz' (and friends) are relying on a `StopWordClassification` for matching. This seems brittle, this PR replaces it with the...

branched from `stopword-classification`, requires https://github.com/pelias/parser/pull/179 be merged first. This PR is an attempt at solving https://github.com/pelias/parser/issues/178 with minimal changes. However, it seems to solve a longstanding issue which was more...

Add support for/test cases covering `bis/ter` housenumber suffixes for French addresses. ``` 1 bis Av. Amélie, 92320 Châtillon, France ``` ```js { "subject": "1 bis Av.", "housenumber": "1", "street": "bis...

bug

The `metroarea` placetype has no parents, is this correct?

We currently have all the Indian PIN codes in https://github.com/whosonfirst-data/whosonfirst-data-postalcode-in but they are all `0,0` geometries: ```sql sqlite> SELECT COUNT(*) from spr; 28212 sqlite> SELECT COUNT(*) from spr WHERE latitude...

[Muir Army Air Field](https://github.com/whosonfirst-data/whosonfirst-data-admin-us/blob/master/data/102/525/173/102525173.geojson) has a label geometry but actual geometry lies at Null Island. ``` "lbl:latitude":40.43481, "lbl:longitude":-76.56941, ``` ``` "geometry": {"coordinates":[0.0,0.0],"type":"Point"} ```

It seems that [Honnelles](https://spelunker.whosonfirst.org/id/1360697009) is part of Belgium, not France 🤔 I wasn't able to find any reference of a French locality by that name, I also checked the location...

The wikipedia says "Bornova is a municipality and [district](https://en.wikipedia.org/wiki/Districts_of_Turkey) of [İzmir Province](https://en.wikipedia.org/wiki/%C4%B0zmir_Province), [Turkey](https://en.wikipedia.org/wiki/Turkey)" https://en.wikipedia.org/wiki/Bornova We currently have the city as a `Point` geometry: - https://spelunker.whosonfirst.org/id/890464333 - https://spelunker.whosonfirst.org/id/890463111 I didn't check...

The current code only checks for duplicate *adjacent* vertices: https://github.com/golang/geo/blob/6adc5660321723185f04b66d66a5563b29228236/s2/loop.go#L251-L260 While the comments say: > Loops are not allowed to have any duplicate vertices (whether adjacent or not) https://github.com/golang/geo/blob/6adc5660321723185f04b66d66a5563b29228236/s2/loop.go#L34-L35

as per https://github.com/pelias/interpolation/pull/274 I have archived the 2024 data to our s3 bucket and made it publicly available via our CDN.