Peter Johnson

Results 297 issues of Peter Johnson

DO NOT MERGE This PR enables multicore support for the interpolation service. I do not think this should be merged in its current state due to: > each process loads...

query for gleimstrasse, berlin fails to match despite having rows in the db (matching logic bug?) ``` /extract/geojson?lat=52.546892&lon=13.404291&names=gleim%20strasse ``` ``` select * from polyline where id = 20012388; 20012388|{qffcBizmqXTdEVlG~H|~BtJrqB\tFpB`d@|Jj}BdEv_AjA~V?jJN|GO}G?kJkA}VeEy_A}Jk}BqBad@]uFuJsqB_I{~BWoGUcEkQexEjQbxE sqlite>...

East 9th Street, Manhattan. Seems like the road goes through the park? The OSM label is also present in the park so maybe the data is wrong? ![park](https://cloud.githubusercontent.com/assets/738069/19440525/8043b6ea-9482-11e6-9618-846c6901dcf2.png)

processed

there appear to be roads where there are no road (polylines do not match base map) 1st avenue, manhattan ![1st_ave](https://cloud.githubusercontent.com/assets/738069/19441258/60e82062-9485-11e6-8f2d-f8c387039ef0.png)

processed

some OA extracts have data in the `UNIT` column which we can use: (this won't have a huge impact, so low priority for now). ``` bash LON,LAT,NUMBER,STREET,UNIT,CITY,DISTRICT,REGION,POSTCODE,ID,HASH -122.3897574,37.7898033,75,Folsom Street,901,,,,94105,,cb3f802c0fbb6877 -122.3897574,37.7898033,75,Folsom...

processed

the `stream/vertices/lookup.js` file contains an SQL query: `SELECT * FROM address WHERE source != "VERTEX" AND id = ? ORDER BY housenumber ASC` when the `ORDER BY housenumber ASC` condition...

processed

some address data contain the housenumber but no street name, eg: http://www.openstreetmap.org/way/182944167#map=19/51.46270/-0.16260 this can be fairly common in OSM because copy->pasting the street name for each building is tedious. MattA:...

processed

it's possible that importers yield 0 rows (for tests and smaller extracts). it seems like the `vertices` action hangs if the address table contains 0 rows, also there are errors...

processed

On the Mac ARM machines this one test fails due to -0 != +0 ``` go test --- FAIL: TestComputeCentroidForClosedPolygon (0.00s) centroid_test.go:84: Error Trace: centroid_test.go:84 Error: Not equal: expected: "0.0000000"...

bug

this PR rewrites some older code in a clearer way, which opens it up for extension. in particular issue https://github.com/pelias/pbf2json/issues/96 could benefit from this refactor some notes on what this...