Peter Johnson

Results 1014 comments of Peter Johnson

Did you try using `npm` instead of `yarn`?

> Could this error be because it does not know where libpostal is installed? Yes exactly, and I apologize but my code snippet may have made that more confused, you...

If you can't get that working then figure out where libpostal was installed and set the `LD_LIBRARY_PATH` env var so it knows where to search. (ie. the path prefix to...

The `--datadir` is usually distinct from the install dir, maybe this is causing issues? Try removing `DESTDIR=/opt/libpostal` we only use that in our docker images for more control, you're probably...

Is that a fatal error or just a bunch of warnings?

I wouldn't worry about the warnings if the software is working as expected.

> Personally I'm in favor of eventually removing the sqlite directory, it's not really meaningful anymore. I do like how this PR handles backwards compatibility, and eventually we can remove...

outstanding question about the `console.debug();` before we merge this.

Worth noting that if you have two databases in the `whosonfirst/sqlite` directory and one in the `whosonfirst` directory that the latter would be silently ignored. This would be the case...

I'm fine with this, @orangejulius it's still showing as still unapproved by you, are you happy with approving it in its current state?