Peter Johnson
Peter Johnson
Worth noting an oddity between the CPP and Go implementations, the edge crossings `Crossing` enum is in a different order, numeric comparisons from the CPP code don't port to Go...
> Where did you do something differently from C++ The main obstacle to a 1:1 port are CPP function overloading, this necessitates some function renaming as Golang doesn't support overloading....
https://github.com/google/s2geometry/blob/0fb1b8a1474f3137c8b44a7861e31f8efd1370e2/src/s2/s2cell_union.cc#L371
Pelias maintains a list of capital cities with WOF concordances for testing purposes: https://github.com/pelias/placeholder/blob/master/test/cases/capitalCities.txt I haven't run that test suite for a while so it might not be 100% up...
Snapshot: https://web.archive.org/web/20240915122011/https://www.geoportal.sk/en/zbgis/download/
If we add this option it should be *per file* rather than *global* IMO. The solution suggested in this issue description would mean that the provided delimiter would be used...
Also worth mentioning the `csv-parse` library we use has an open issue to automatically discover delimiters. We could simply wait for that to land and avoid introducing any changes to...
My preference would be to wait for the linked PR to land and then enabling the auto-discover option.