Peter Johnson comments

Results 1014 comments of


                                            Peter Johnson

Add ISO639 official language codes

I think these are technically named [ISO 639-1](https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes) codes, let me know if you think I should rename the field.

Add ISO639 official language codes

Maybe I should also split the strings into an array 🤔

[docs] fix minor typo

the units tests seem to be failing for an unrelated issue.

[German] donation of new resources

:+1: I would also be interested in the German data for Pelias

Label-Placement outside geometry results in wrong hierarchy

Hmmm yeah, this is clearly a bug. I believe [mapshaper](https://github.com/mbloch/mapshaper) is being used to generate these label centroids.

Label-Placement outside geometry results in wrong hierarchy

I had a deeper look into this and unfortunately it seems to affect many records, steps to reproduce: ```sql SELECT id, json_extract(body, '$.properties.lbl:latitude') AS lat, json_extract(body, '$.properties.lbl:longitude') AS lon FROM...

Label-Placement outside geometry results in wrong hierarchy

I can save you some time: https://gist.github.com/missinglink/0662d6b500055614eb5349c4638b5a88

Label-Placement outside geometry results in wrong hierarchy

We could change the spatial predicate from `Contains` to `Intersects` and it should work for all geometry types including Points & Lines.

Label-Placement outside geometry results in wrong hierarchy

I'm really not familiar with the old python code which I believe is still being used for the PIP work. It should be easy enough for someone who knows it,...

Label-Placement outside geometry results in wrong hierarchy

We just need some way of making sure the label centroids are actually inside the shape because they are being used later to establish the admin hierarchy.