Peter Johnson

Results 1014 comments of Peter Johnson

There isn't a method to update an existing instance, it always requires a rebuild by design. Because of the dependencies, this change won't be pulled into the [pelias/openaddresses:master](https://hub.docker.com/r/pelias/openaddresses) docker image...

I just merged a PR on pelias/openaddresses, once this job completes then you can pull the latest docker images and rebuild https://github.com/pelias/openaddresses/actions/runs/1723109743

FYI https://github.com/paulmach/orb/blob/master/planar/contains.go

Yes, unfortunately, I have run it to it a few times, I have a library based off this parser https://github.com/missinglink/pbf which has a bunch of different commands available. In that...

something like this: ```go package main import ( "flag" "fmt" "log" "os" "sync" "github.com/thomersch/gosmparse" ) type handler struct { nodes map[int64]gosmparse.Node mutex *sync.Mutex } func (d *handler) ReadNode(n gosmparse.Node) {...

I really like this library and I changed to using it over another one, unfortunately having to do multiple passes on the file negates the speed benefits of this library...

would it make sense to store the `wkb` fixtures in `[]byte` instead of `string`? wrangling hex strings in order to test binary operations is a bit of extra work and...

Hi @peterstace sorry for the long delay, this should be good to go now. I wasn't able to figure out a nice way of getting the call to `hexStringToBytes()` outside...

In regards to code organization, are you happy with this `geom/wkb_bench_test.go` file or would you prefer to move the `BenchmarkWKBParse` into `geom/wkb_test.go`? I know some people prefer to have their...

@pointOfive I don't believe it's possible to have a single canonical representation of all addresses in all locales (although it is easier in English). For example, the humorously named `Max-Beer-Straße`...