gitlab-webhooks
gitlab-webhooks copied to clipboard
miso-belica
Tag pushes and unauthenticated email
don't try to login to smtp server if we don't have a username watch for tag pushes
- @tags/tagprefix-*
I failed to test it completely and found an issue with it. I'm still working it out. I'll resubmit once I get that fixed. Sorry about that.
Mike Nestor c: 410-588-9704
On Sat, Jul 26, 2014 at 6:27 AM, Mišo Belica [email protected] wrote:
Why did you close the PR? Not useful anymore?
— Reply to this email directly or view it on GitHub https://github.com/miso-belica/gitlab-webhooks/pull/1#issuecomment-50230451 .
Ok then, let me ask you one question. What is advantage to use branch name after URL and @ character? It seems to me it's just more work with it.
And I prefer smaller commits (one feature/fix per commit) so please have it in mind when you send new PR. I can think about this as 2 fetures (anonymous mail & config file format change). Thanks :)
Everyone wants their pull requests different. I'm not great with git but I'll try to split that. I'd just gotten used to rebase/squash before a pull request.
Having the branch after, I also set it up for tags too, allows for multiple versions on the same system.
So if you have limited resources and need to setup a staging/production setup on the same server you can setup autodeploy for them both. If that wasn't at the end then the last section would be the one used from the config.
So in my case I have @master branch and tag things when ready for staging @staging-v0.1 on the same server. /opt/blklst/master /opt/blklst/staging
That way I have a way to test deployments automatically before going to my production system.
Mike Nestor c: 410-588-9704
On Sat, Jul 26, 2014 at 10:51 AM, Mišo Belica [email protected] wrote:
Ok then, let me ask you one question. What is advantage to use branch name after URL and @ character? It seems to me it's just more work with it.
And I prefer smaller commits (one feature/fix per commit) so please have it in mind when you send new PR. I can think about this as 2 fetures (anonymous mail & config file format change). Thanks :)
— Reply to this email directly or view it on GitHub https://github.com/miso-belica/gitlab-webhooks/pull/1#issuecomment-50236163 .
I understand. I have private branch of this repo where config file is in JSON and I can finish it and add support for multiple branches/tags there :) What do think about that?
That works too. I should have it all finished up Monday to submit the pull again. Just glad someone had done most of the legwork for a solution that would work for me so I'm happy to send my stuff up, provided it works :)
I was also starting to do some more checking so it wouldn't throw exceptions so much. It's all on my work system so I can send it to you Monday if you want to see it.
Mike Nestor c: 410-588-9704
On Sat, Jul 26, 2014 at 4:36 PM, Mišo Belica [email protected] wrote:
I understand. I have private branch of this repo where config file is in JSON and I can finish it and add support for multiple branches/tags there :) What do think about that?
— Reply to this email directly or view it on GitHub https://github.com/miso-belica/gitlab-webhooks/pull/1#issuecomment-50247925 .
https://github.com/mnestor/gitlab-webhooks
I was also toying with the thought of a post-merge command. Right now I've setup a post-merge hook but that gets in the way when I'm doing stuff manually. I was thinking it would be cleaner to setup a command that would be executed here instead.