Mislav Marohnić
Mislav Marohnić
The "files" output isn't a list of files where shellcheck has detected violations, but the full list of files that shellcheck was invoked on.
Previously, this was an often-repeated construct in readability implementation: charCount(ps.getInnerText(node, true)) == 0 What this would do is: - Call `dom.TextContent(node)` to append the contents of all individual text nodes...
This markup from Medium would result in an empty `` element after making readable: ```html ``` 1. Readability removes the `img` element with an empty src; 2. The `div` is...
By default, `Parser.Debug` property is false and writing to the logger is disabled. However, invocations of `Parser.logf()` would still happen regardless of the Debug property, which included arguments that were...
When `Test_parser()` iterates over the myriad test pages in the suite, if any parsed text for an article doesn't match what's in the `expected.html` fixture, the test will generate a...
I've discovered this when I was debugging why the table of contents of [a very large document](https://koreader.rocks/user_guide/) didn't work anymore after being processed by go-readability. Some documents use DIVs instead...
The `script/generate-test` script fetches a HTML page and stores its parse result as a test expectation. However, published & modified timestamps were not persisted, even when they were correctly extracted...