Mislav Marohnić comments

Results 921 comments of


                                            Mislav Marohnić

Running without an argument will destoy origin/master

I'm sorry that happened. I'll try to see what's going on there.

Running without an argument will destoy origin/master

Thanks for the explanation. How did it destroy the master branch, though?

hanna --gems fails with 1.9.2

Hmm I didn't know that. How are these "system" gems different? Thanks for reporting this

avoid lossing body when parsing html

Interesting. I'm not sure about this implementation but I need to investigate that original claim about losing the `` element.

pjax form submit heroku example

Thanks for the submission. What were you trying to do here?

pjax form submit heroku example

Gotcha. Well, your pull request is based on a commit that's very old: from year 2012 it seems. Then you upgraded the library files in the commit "Update jquery and...

pjax form submit heroku example

Oh I'm sorry, I provided you with wrong instructions. I thought that you opened a PR for our "master" branch, like most of our PRs. But you made a perfectly...

Add support of unicode characters for X-PJAX-URL

Couldn't Unicode characters simply appear in the header value verbatim, i.e. unescaped?

Question: Is it possible to get data attribute from fragment or fragment's parent?

Body class changing sounds like application-specific logic, so it would be best handled by adding pjax lifecycle event handlers tailored for your app. The "pjax:end" event is suitable since it...

Question: Is it possible to get data attribute from fragment or fragment's parent?

Yes, your initial idea sounds simpler even to me, but might be slightly harder to implement. You could sift through the original HTML (before pjax extracts the fragment) like so:...