phone-number-bundle icon indicating copy to clipboard operation
phone-number-bundle copied to clipboard

Add support for bootstrap_4(_horizontal)_layout.html.twig

Open mathiasstocker opened this issue 7 years ago • 11 comments
trafficstars

mathiasstocker avatar May 14 '18 13:05 mathiasstocker

Just looking very briefly I’m not sure what this code is originally for - did you work it out?

robhogan avatar May 14 '18 19:05 robhogan

Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4: https://symfony.com/doc/current/form/form_customization.html#what-are-form-themes

The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4.

This pull request fixes this issue.

mathiasstocker avatar May 28 '18 05:05 mathiasstocker

Also see #179

mathiasstocker avatar May 28 '18 05:05 mathiasstocker

+1, need this fix

claire1604 avatar Jun 22 '18 08:06 claire1604

+1

ruscon avatar Aug 25 '18 12:08 ruscon

Until this is fixed you can use my fork: https://github.com/mathiasstocker/phone-number-bundle

@rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured

mathiasstocker avatar Aug 25 '18 12:08 mathiasstocker

any update about this PR?

kariae avatar Nov 04 '18 13:11 kariae

Can we expect a solution for bootstrap 4 forms ? Is is still not working...

effetb avatar Jan 11 '19 10:01 effetb

Hi, why about one year later this pull request is still not accepted ?

effetb avatar Apr 10 '19 10:04 effetb

@rh389 Hi, can you accept up this PR please ?

florianlemenach avatar May 28 '19 09:05 florianlemenach

If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle We would be happy to merge this :)

maxhelias avatar Nov 28 '19 12:11 maxhelias