phone-number-bundle icon indicating copy to clipboard operation
phone-number-bundle copied to clipboard

Published 20 hours ago • verified publisher icon misd-service-development

phone number format as option instead of hard set to NATIONAL

Open pierreboissinot opened this issue 6 years ago • 9 comments

behavior like single_text widget)

pierreboissinot avatar Mar 09 '18 09:03 pierreboissinot

Resolves #171

pierreboissinot avatar Mar 09 '18 09:03 pierreboissinot

Hi, the travis configuration seems broken

pierreboissinot avatar Mar 09 '18 09:03 pierreboissinot

Thanks for the PR. Travis seems to be fine, but this change is causing tests to fail because you’ve changed the default format to INTERNATIONAL.

robhogan avatar Mar 09 '18 11:03 robhogan

Ok thanks @rh389 I'm updating the test case.

pierreboissinot avatar Mar 09 '18 13:03 pierreboissinot

@rh389 tests passed =).

pierreboissinot avatar Mar 09 '18 13:03 pierreboissinot

@rh389 default format set to NATIONAL

pierreboissinot avatar Mar 09 '18 14:03 pierreboissinot

Hi @rh389 , I added some tests and a "hack" to prevent any regression: the form option format depends on widget. See https://github.com/misd-service-development/phone-number-bundle/pull/173/commits/8cd7a42e6512f07ee0f96d4426b93a17e1b2d8d2

pierreboissinot avatar Mar 13 '18 13:03 pierreboissinot

hi @rh389 , do you validate the tests ?

pierreboissinot avatar Mar 23 '18 10:03 pierreboissinot

@rh389 ping

jkabat avatar Nov 05 '19 16:11 jkabat