Josephine Lim

Results 209 comments of Josephine Lim

+1 for Jetpack Compose, if we aren't using it already. It seems to be the [official recommendation](https://developer.android.com/develop/ui/compose) for future-proof UI development.

> > +1 for Jetpack Compose, if we aren't using it already. It seems to be the [official recommendation](https://developer.android.com/develop/ui/compose) for future-proof UI development. > > Am I good to go...

When you say "no data to populate list view", do you mean that the user is offline? In that case, I think the text "No connection, unable to load contributions/nearby...

Hi @veryveryharry , that would be great! I think you can collaborate with @devaar100 for this, where you could create the images (license as CC0 if possible please) and he...

Yes, for the blank screens. :) The mocks look great IMO! I agree that they are consistent with the style in the tutorial. I would probably make the images a...

@neslihanturan I don't think he was asking us to choose - I think the 3 columns correspond to 3 different scenarios - (1) user hasn't uploaded anything yet, (2) user...

Yeah, I agree with the middle image for "no uploads yet". However, for the person who implements this... The text: > **No Recent Uploads** > Make a contribution to Wikimedia...

Hi @Adeeth101 , I believe our [contribution guidelines](https://github.com/commons-app/commons-app-documentation/blob/master/android/Contributing-Guidelines.md) are that unit tests are required for new features and enhancements. As this issue is an enhancement, I'd strongly recommend implementing basic...

@nicolas-raoul Possible! We'll try it out with a direct query first.