Michael Nikitochkin

Results 141 comments of Michael Nikitochkin

I missed this feature as well. It would avoid to create custom metrics and instead of this just add labels to the existing prometheus metrics.

@moshloop I might be misunderstanding the title, but I’m aiming to add a limited number of custom tags to all metrics produced by Canarychecker's probes. For example: ``` - http:...

> I think having both branch and commit is the issue. On update the resolver might only consider the branch ref, and overlook the commit ref. I had the same...

Here are my small observations around the `branch` vs. `commit` directive usage: `shards.lock` looks like: ```yaml pg: git: https://github.com/will/crystal-pg.git version: 0.29.0+git.commit.cafe112f2847f366262460ee999e74f9c7e8b31c ``` 1. Using both `branch` and `commit` at the...

I have figured out the problem. After I cleaned the cache folder, I could no longer reproduce the issue. ```shell $ rm -fr ~/.cache/crystal/ $ rm -fr ~/.cache/shards/ ```

The way how I reproduced the problem. 1. Clone the https://github.com/martenframework/marten/ 2. Run the `shards` from the `marten`: ```shell $ shards Resolving dependencies Fetching https://github.com/crystal-lang/crystal-mysql.git Fetching https://github.com/crystal-lang/crystal-sqlite3.git Fetching https://github.com/crystal-community/timecop.cr.git Fetching...

**My findings so far:** The package in `lib/pg` is refreshed during the `marten` **Postinstall** step. The `shard.yml` of Marten looks like this: ```yaml scripts: postinstall: scripts/precompile_marten_cli ``` The script looks...

I have replaced `shard build` with `crystal build` to avoid a mess with the `lib` folder. https://github.com/miry/marten/commit/8e3c9a4991ca52f4b57fcd92c0c382f0811cfde3 I dunno what could be improved or done to prevent similar issues in...

Would it be possible to share the `shard.lock` file with dependencies in the same way as the `lib` folder?

Is it related to https://github.com/flanksource/canary-checker/issues/2227?