Mirus

Results 28 comments of Mirus

Added your name to week_number.jsx

6.6% 💪 ![Знімок екрана 2024-04-23 о 17 15 33](https://github.com/Hacker0x01/react-datepicker/assets/29524085/722ca726-4178-469e-9a2e-237453fe7e85)

@maranomynet hello Can you update your PR based on this one https://github.com/Hacker0x01/react-datepicker/pull/4707 and then we can do a major release, including your breaking changes

@martijnrusschen hello this PR looks promising. Should we try to adapt it for v7 with the rest of the breaking changes?

@martijnrusschen hello. Please ask reviews to look at four opened PRs if you can. It'll be much faster if we merge them because the rest of the modules depend on...

> @mirus-ua Modifications to index.jsx may need to be synchronized with modifications to calendar.jsx. (especially the props type) Would it be ok if I work on it all together? sure,...

@yuki0410-dev almost everything was merged, so you can start with the final part

> what's left? The core features are done.But I think better to migrate some amount of tests just to double check that all types are OK

> @mirus-ua I noticed during my experimentation with #4810 that type errors in the test file do not seem to result in errors in CI. Is it my understanding that...

The types for v 6.2.0 are managed by the external package. You can reopen the issue there or wait until v7