ariadne icon indicating copy to clipboard operation
ariadne copied to clipboard

Use poetry for package

Open rafalp opened this issue 6 years ago • 3 comments
trafficstars

With PIP 19 being released, we can safely move Ariadne to Poetry removing the need for maintaining separate requirements* files or setup.py.

TODO

  • [x] Create pyproject.toml
  • [ ] Add requirements using Poetry
  • [ ] Remove setup.py
  • [ ] Remove requirements files
  • [ ] Update Travis config
  • [ ] Add config for black to exclude snapshot directory

rafalp avatar Mar 27 '19 18:03 rafalp

@NyanKiyoshi from what I know pyproject.toml replaces setup.py altogether, with PIP 19 reading the build tool from it and following from there with poetry.

No idea yet when we will want to merge this PR. May want to wait a few months so Poetry 1.0 ships.

rafalp avatar Apr 01 '19 11:04 rafalp

FWIW, I've recently abandoned Poetry to go back to requirements files because of frequent breaking changes between pip and poetry. The unexpected thing was these issues would appear at package install time in my apps. This forced my apps to downgrade pip to compatible versions until the lib got upgraded to a newer version of poetry that was compatible with the latest pip which was unacceptable for a tool I viewed as a dev only packaging convenience.

nikordaris avatar May 16 '20 12:05 nikordaris

We're not planning to drop requirements.txt, just change the tool we use to maintain it.

patrys avatar May 18 '20 10:05 patrys