[Bug] Changing BorderThickness will cause an exception to be displayed when nodes are selected

[Maklith]

Describe the bug If BorderThickness is changed to a value not equal to 1, it will cause an abnormal display when the node is selected. If it is selected, the node will move slightly Modifying BorderBrush will cause SelectedBrush to be modified together and the SelectedBrush modifications to be invalid It is also not possible to change the Selected BorderThickness To Reproduce change ItemContainer style <Setter Property="BorderThickness" Value="2"></Setter>

Expected behavior No displacement

Screenshots

Additional context Add any other context about the problem here.

[miroiu]

Hi, I created a PR for this. Can you please check it out and let me know if that's what you expected? Thanks!

[Maklith]

the PR is working

[Maklith]

Another question Modifying BorderBrush will cause SelectedBrush to be modified at the same time, which will cause the SelectedBrush modification to be invalid

[Maklith]

like this SelectedBrush modification is invalid

One idea is to modify SelectedBrush synchronously when only BorderBrush is modified, but when SelectedBrush is manually specified, the manually specified SelectedBrush will prevail

[miroiu]

I merged the fix for border thickness and I replicated the selected brush issue, but I don't understand why it doesn't work as expected.

[miroiu]

Let me know if anyone wants to give it a try.