ocaml-tls icon indicating copy to clipboard operation
ocaml-tls copied to clipboard

Implement V1_LWT.FLOW disconnect

Open djs55 opened this issue 9 years ago • 2 comments

FLOW.close should flush data and signal to the remote that no more data will be written.

FLOW.disconnect should disconnect from the flow immediately without signalling and possibly drop in-flight/in-buffer data.

FLOW.close should act like Unix.shutdown while FLOW.disconnect should act like Unix.close.

This patch implements FLOW.disconnect by setting any Active connection to Eof (hopefully the GC will deallocate it later) and calling disconnect on the underlying flow.

Related to [mirage/mirage#550]

Signed-off-by: David Scott [email protected]

djs55 avatar Jul 20 '16 15:07 djs55

Is this still relevant?

LGTM

pqwy avatar Oct 24 '16 11:10 pqwy

it seems relevant, but let's wait till https://github.com/mirage/mirage/pull/550 is merged

hannesm avatar Oct 24 '16 12:10 hannesm

thanks a lot, this has been superseeded by #488

hannesm avatar Mar 21 '24 20:03 hannesm