Does Not Work with 1.17 due to negative block height

[evvanErb]

trafficstars

Describe the bug Short description of what the bug is.

Error downloading chunk due to negative block height

Steps to reproduce If possible, describe how the bug can be achieved. I have Java 16 and the server is running Minecraft 1.17. On connection to localhost immediate error in the program with the following error. It seems the error is due to the program trying to encode the extended block height of 1.17 (which now ranges from negative vals to past 256 in this update). Using the latest release version of this program for windows.

Use with 1.17

Log output

java.lang.ArrayIndexOutOfBoundsException: Index -11 out of bounds for length 256
	at game.data.chunk.version.encoder.BlockLocationEncoder_1_16.fetch(BlockLocationEncoder_1_16.java:19)
	at game.data.chunk.ChunkSection.getPaletteIndex(ChunkSection.java:126)
	at game.data.chunk.ChunkSection.getPaletteIndex(ChunkSection.java:118)
	at game.data.chunk.ChunkSection.getNumericBlockStateAt(ChunkSection.java:114)
	at game.data.chunk.Chunk.getNumericBlockStateAt(Chunk.java:307)
	at game.data.chunk.Chunk.getBlockStateAt(Chunk.java:315)
	at game.data.chunk.Chunk.getBlockStateAt(Chunk.java:311)
	at game.data.chunk.ChunkEntities.addTileEntity(ChunkEntities.java:108)
	at game.data.chunk.ChunkEntities.addTileEntity(ChunkEntities.java:142)
	at game.data.chunk.Chunk.parseTileEntities(Chunk.java:285)
	at game.data.chunk.version.Chunk_1_17.parse(Chunk_1_17.java:70)
	at game.data.chunk.ChunkFactory.parseChunk(ChunkFactory.java:108)
	at game.data.chunk.ChunkFactory.readChunkDataPacket(ChunkFactory.java:125)
	at game.data.chunk.ChunkFactory.parse(ChunkFactory.java:85)
	at game.data.chunk.ChunkFactory.lambda$addChunk$1(ChunkFactory.java:72)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:831)
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!

 java.lang.ArrayIndexOutOfBoundsException
Chunk could not be parsed!
...

Screenshots If applicable, add screenshots to help explain your problem.

Version

• Game: Minecraft 1.17
• Downloader: latest
• Launcher (if login issues): 14.2

[mircokroon]

Ah, I guess I never tried this since it wont be enabled by default until 1.18. I'll see if I can do something about it.

[mircokroon]

Hmm I'm not able to reproduce this specific error, I did fix a few other issues with coordinates below 0 and above 256 so maybe one of those caused this

[Nullbczd]

Ah, I guess I never tried this since it wont be enabled by default until 1.18. I'll see if I can do something about it. Some 1.17.1 servers added 1.18 preview packets，Is there no solution for such a server？

[mircokroon]

Well, I set up a server with negative block heights and fixed that. Is this issue still occurring?

[Nullbczd]

Well, I set up a server with negative block heights and fixed that. Is this issue still occurring? Server IP address is server.mcbar.club java.lang.ArrayIndexOutOfBoundsException: Index -139 out of bounds for length 256 at game.data.chunk.version.encoder.BlockLocationEncoder_1_16.fetch(BlockLocationEncoder_1_16.java:19) at game.data.chunk.ChunkSection.getPaletteIndex(ChunkSection.java:126) at game.data.chunk.ChunkSection.getPaletteIndex(ChunkSection.java:118) at game.data.chunk.ChunkSection.getNumericBlockStateAt(ChunkSection.java:114) at game.data.chunk.Chunk.getNumericBlockStateAt(Chunk.java:307) at game.data.chunk.Chunk.getBlockStateAt(Chunk.java:315) at game.data.chunk.Chunk.getBlockStateAt(Chunk.java:311) at game.data.chunk.ChunkEntities.addTileEntity(ChunkEntities.java:108) at game.data.chunk.ChunkEntities.addTileEntity(ChunkEntities.java:142) at game.data.chunk.Chunk.parseTileEntities(Chunk.java:285) at game.data.chunk.version.Chunk_1_17.parse(Chunk_1_17.java:70) at game.data.chunk.ChunkFactory.parseChunk(ChunkFactory.java:108) at game.data.chunk.ChunkFactory.readChunkDataPacket(ChunkFactory.java:125) at game.data.chunk.ChunkFactory.parse(ChunkFactory.java:85) at game.data.chunk.ChunkFactory.lambda$addChunk$1(ChunkFactory.java:72) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) at java.base/java.lang.Thread.run(Thread.java:831) Chunk could not be parsed!

java.lang.ArrayIndexOutOfBoundsException

java.lang.ArrayIndexOutOfBoundsException Chunk could not be parsed!

[Whippsie]

Still occuring in 2022