ember-cli-mirage icon indicating copy to clipboard operation
ember-cli-mirage copied to clipboard

MirageJS as peer dependency

Open cah-brian-gantzler opened this issue 3 years ago • 2 comments
trafficstars

This makes MirageJS a peer dependency. This is a breaking change. Any existing applications using ember-cli-mirage will have to rerun the default blueprint ember install ember-cli-mirage or add miragejs to your package.json mannually.

Fixes: https://github.com/miragejs/ember-cli-mirage/issues/2416

cah-brian-gantzler avatar May 22 '22 14:05 cah-brian-gantzler

Would you be opposed to adding Husky. I have it on my own apps so keep forgetting to run lint and prettier prior to submitting PRs :)

cah-brian-gantzler avatar May 22 '22 15:05 cah-brian-gantzler

This is a good change, without it people cannot reliably adopt the new pattern that is documented for 3.0 (importing directly from miragejs).

ef4 avatar Jul 05 '22 21:07 ef4