ember-cli-mirage icon indicating copy to clipboard operation
ember-cli-mirage copied to clipboard

uses old version of ember-get-config so ember-dependency-lint fails

Open BryanCrotaz opened this issue 4 years ago • 9 comments

This addon uses ember-get-config 0.3.0. The latest is 0.5.0

BryanCrotaz avatar Nov 07 '21 22:11 BryanCrotaz

I've raised https://github.com/miragejs/ember-cli-mirage/pull/2242 which bumps the minimum version of ember-get-config to ^0.3.0. Whilst this doesn't bump to latest as you have requested it does resolve some deprecation warnings. Unsure if this is what you were after or the reasoning behind going to latest is but ya thought I would mention here just incase its relevant.

rahulk94 avatar Nov 18 '21 23:11 rahulk94

Why not bump to latest?

Because it's a zero major version you can't make it play nice with resolutions, so dependency lint fails the test run because it's an old version that literally no one else is using

BryanCrotaz avatar Nov 18 '21 23:11 BryanCrotaz

I've gone for the safest/most un-intrusive fix in my PR just to clear deprecations (which can then go out in a service pack here).

I agree with you that this project should at some point be updated to use 0.5.0 though to fix dep linting but from a quick look, 0.5.0 drops Ember < 3.4 support. No clue if this matters for ember-cli-mirage as I don't see its support matrix anywhere.

https://github.com/miragejs/ember-cli-mirage/issues/2240 probably needs resolution before there can be any real changes on this project now though since it doesn't look very maintained atm.

rahulk94 avatar Nov 18 '21 23:11 rahulk94

Ember try only does 3.20. Should probably add a few more backwards and see where it breaks

cah-brian-gantzler avatar Nov 19 '21 14:11 cah-brian-gantzler

Updated ember try in a test and ember-cli-mirage requires 3.4+

Sorry, the tests require 3.4+ the addon may not. (The error when running under 2.18 was something to do with aria-labels). This is the issue when upgrading ember-cli-addon-docs, the requirement for the tests are greater than that of the addon.

cah-brian-gantzler avatar Nov 20 '21 20:11 cah-brian-gantzler

Likewise the tests dont run under 3.28 but it looks like the addon docs portion of the dummy app not the actual tests themselves :(

cah-brian-gantzler avatar Nov 20 '21 20:11 cah-brian-gantzler

The package.json has been updated

"ember-get-config": "0.2.4 - 0.5.0",

And a release 2.3.0 has been published.

Please let us know if this does not help with the problem

cah-brian-gantzler avatar Jan 12 '22 21:01 cah-brian-gantzler

get-config now has a 1.0 release!! Bumping to that should place much nicer across the addon ecosystem as everything won't have to stay as in sync anymore.

jrjohnson avatar Jan 13 '22 18:01 jrjohnson

@jrjohnson it's on radar! we'll upgrade ember-get-config to v1 in ember-cli-mirage v3 release as ember-get-config@1 dropped support for Node.js 10

SergeAstapov avatar Jan 13 '22 18:01 SergeAstapov