ember-cli-mirage icon indicating copy to clipboard operation
ember-cli-mirage copied to clipboard

Added embroider-safe and embroider-optimized to the test scenarios

Open cah-brian-gantzler opened this issue 4 years ago • 3 comments

cah-brian-gantzler avatar May 08 '21 15:05 cah-brian-gantzler

@cah-briangantzler in the next release of Embroider we will handle the webpack dependency within the helpers so that dep does not need to be explicitly set. So it might be worth waiting for that

thoov avatar May 18 '21 15:05 thoov

Good to know. Since the change was just made to require the app to do the webpack, I should have just added webpack as a devDependancy instead of what I did and figured that was the desired direction.

cah-brian-gantzler avatar May 18 '21 15:05 cah-brian-gantzler

Oh nice to see this is already raised @cah-briangantzler. If ya upgrade your dependency of the @embroider/test-setup to the latest now you should be able update remove the explicit webpack handling as @thoov mentioned earlier 🙂

rahulk94 avatar Nov 18 '21 20:11 rahulk94