ember-cli-mirage icon indicating copy to clipboard operation
ember-cli-mirage copied to clipboard

0.4.15 requires Node 10+, which seems like a breaking change from 0.4.14

Open EndangeredMassa opened this issue 4 years ago • 1 comments

I'm upgrading an old project from [email protected]. When I hit the step to upgrade to 0.4.*, I went for 0.4.15 to see what worked. I then saw that this dependency exists:

[email protected] -> ember-auto-import -> jsdom -> [email protected]

Unfortunately, [email protected] uses optional catch binding, which means it requires Node 10+. It seems that adding ember-auto-import is the source of this issue.

It looks like at the time of publication, ember-cli-mirage0.4.15 may have been compatible with Node 8. But now it is not.

I don't see any mention of explicit Node version support in ember-cli-mirage. However, going from 0.4.14 to 0.4.15 means that the supported Node version does change.

I don't know if you want to fix this. Feel free to close if not. But if you do, maybe a 0.4.16 release that locks that dependency down would be in order.

Regardless, can you add a breaking change note to 0.4.15 saying this is the case?

EndangeredMassa avatar Jan 22 '21 17:01 EndangeredMassa

Updated the release notes, sorry you ran into that!

Happy to merge a PR that locks that dep + publish as 0.4.16, if someone gets around to it 👍

samselikoff avatar Feb 01 '21 16:02 samselikoff