ember-cli-mirage icon indicating copy to clipboard operation
ember-cli-mirage copied to clipboard

Can we have TypeScript @types?

Open quantuminformation opened this issue 7 years ago • 9 comments

This is the issue I'm having so its related

https://github.com/cowboyd/mirage-server/issues/6

quantuminformation avatar Dec 11 '17 11:12 quantuminformation

@QuantumInformation I don't think folks would be opposed, but most people responsible for Mirage are also fairly slammed. Would you be able to send over a PR?

acorncom avatar Dec 21 '17 01:12 acorncom

TypeScript is on my radar but there's some effort to get it into the lib. This is not actionable at the moment so I'll close this issue.

If you'd like to help with the effort, let me know and I'd be happy to help guide.

samselikoff avatar Jan 15 '18 15:01 samselikoff

There's some good definitions being used in the ember-osf-web repo here. If anyone needs these types, copying them into your own app is a good starting place.

AvremelM avatar Nov 25 '18 21:11 AvremelM

Opening so we can track upvotes

samselikoff avatar Nov 26 '18 15:11 samselikoff

This PR is in progress over on miragejs! https://github.com/miragejs/miragejs/pull/262

There's also a feature request issue: https://github.com/miragejs/miragejs/issues/225

Going to close this one.

samselikoff avatar Jan 30 '20 22:01 samselikoff

@samselikoff can we keep this open until ember-cli-mirage updates to a version of miragejs that includes miragejs/miragejs#262?

patrickberkeley avatar Oct 01 '21 15:10 patrickberkeley

Yep absolutely!

samselikoff avatar Oct 01 '21 16:10 samselikoff

PS I haven't been maintaining, there was some talk about moving ember-cli-mirage to adopted-ember-addons. Might be worth pinging @MelSumner about it!

samselikoff avatar Oct 01 '21 16:10 samselikoff

Thanks for reopening and the info @samselikoff !

patrickberkeley avatar Oct 01 '21 16:10 patrickberkeley