ocaml-git icon indicating copy to clipboard operation
ocaml-git copied to clipboard

Do not append a leading slash to path

Open reynir opened this issue 1 year ago • 1 comments

I found that I could not fetch the repo http://git.data.coop/halfd/new-website.git. With full debug logs I was able to gather that http://git.data.coop//halfd/new-website.git was requested instead, and gitea treats that as an error and returns 404.

This PR removes the extra leading slash and adds a test case.

reynir avatar Jul 23 '22 22:07 reynir

There are similar errors in Smart_git.Endpoint.pp for git protocol and likely generic scheme protocol.

reynir avatar Jul 23 '22 22:07 reynir

I just run into this issue as well... would be great to have it merged & released :)

hannesm avatar Aug 25 '22 18:08 hannesm

Thanks, I will cut a release as soon as I can.

dinosaure avatar Aug 27 '22 12:08 dinosaure