Generic client should not emit an INFO log line for every call
Hi ocaml-cohttp maintainers,
We are in the process of migrating our codebase to use, among other things, cohttp-eio. We've noticed a deludge of INFO-level log lines being emitted by the generic client. This breaks the guidance from the Log library around libraries logging on the default source.
I'd propose that we remove this log line outright, if not downgrade it to DEBUG. INFO is, in our opinion, overly-verbose when integrated into a larger application (our non-DEBUG log levels are intentionally pretty minimal so this really clutters up out log with no way to turn off conditionally, and it's ultimately redundant with contextual logging that we do ourselves.). One could also argue for that for the Eio and other async clients specifically, this might result in a blocking call.
(Probably, the broader fix is to move to Log.Srcs? But, at minimum, downgrading it to DEBUG would address our primary request here.)
Thanks for maintaining the project, Nathan
I think this is related to https://github.com/mirage/ocaml-cohttp/issues/1103 , and perhaps if that were fixed then the noise here wouldn't be an issue?
Ah, thanks, Shon, I missed the other ticket being filed. I think that's right, simply logging on a different source would be the ideal fix, I think.