mirage-fs-unix

mirage-fs-unix copied to clipboard

windows: FS.stats can raise `Sys_error`

1

On windows, it seems that `FS.stats`can raise `Sys_error`, which is not appropriately translated into an `Error` value (and so the caller has to wrap that call in a `Lwt.catch`statement)

samoht

See https://ci.appveyor.com/project/samoht/ocaml-git-7vmk0/build/1.0.104 ``` #=== ERROR while compiling mirage-fs-unix.1.2.1 ===============================# # opam-version 1.3.0~dev (98188f141dbeb429258f2b2c00f6240d0af02b84) # os win32 # command make test # path C:/cygwin/home/appveyor/.opam/4.02.3+mingw64c/build/mirage-fs-unix.1.2.1 # exit-code 2 # env-file C:/cygwin/home/appveyor/.opam/4.02.3+mingw64c/build/mirage-fs-unix.1.2.1\mirage-fs-unix-296-08c610.env #...

samoht

Very slow

2

Splitting the filename of every FS operation is _very_ slow. We should use something better (such as `Bos.Path`) when it is ready. /cc @dbuenzli

samoht