irmin icon indicating copy to clipboard operation
irmin copied to clipboard

Remove irmin-http

Open zshipko opened this issue 2 years ago • 2 comments

  • Removes irmin-http since it no longer works with generic key stores
  • irmin-graphql should be the preferred method of interacting with a remote irmin store using high-level operations
  • irmin-server/irmin-client should be used instead of irmin-http for low-level operations. Both irmin-http and irmin-server provide clients that implement Irmin.S, however irmin-server is more optimized and also provides a Batch API that can be used to reduce the number of requests needed to perform an operation.

zshipko avatar Jun 18 '22 00:06 zshipko

Codecov Report

Merging #1902 (15a1982) into main (7065c66) will increase coverage by 0.63%. The diff coverage is n/a.

:exclamation: Current head 15a1982 differs from pull request most recent head b0cb4b7. Consider uploading reports for the commit b0cb4b7 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
+ Coverage   68.16%   68.80%   +0.63%     
==========================================
  Files         137      132       -5     
  Lines       16652    16165     -487     
==========================================
- Hits        11351    11122     -229     
+ Misses       5301     5043     -258     
Files Changed Coverage Δ
src/irmin-cli/cli.ml 21.46% <ø> (+0.72%) :arrow_up:
src/irmin-cli/resolver.ml 54.54% <ø> (+0.90%) :arrow_up:

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 23 '22 23:06 codecov-commenter

Will merge this once irmin-server is ready to be integrated

samoht avatar Jul 07 '22 07:07 samoht

@zshipko think we can close this in favor of https://github.com/mirage/irmin/pull/2031?

metanivek avatar Nov 04 '22 15:11 metanivek

Hm, yeah this can be closed but there could also be a case to be made for removing irmin-http before irmin-server is integrated since there are still some details to figure out in regards to #2031

zshipko avatar Nov 04 '22 16:11 zshipko

Got it. As long as these ship together in a release, I'm fine to keep them separate PRs. Could you make #2031 just about adding irmin-server? Then we can keep this PR as the irmin-http removal PR.

metanivek avatar Nov 04 '22 17:11 metanivek