freyr-js icon indicating copy to clipboard operation
freyr-js copied to clipboard

It seems that other language is not supported by youtube downloader

Open wisetc opened this issue 2 years ago • 9 comments

It seems that language and location params are configured fixed

{
  hl: 'en',
  gl: 'US',
}

Can we set it dynamically?

wisetc avatar Sep 08 '23 14:09 wisetc

Can you provide a use case? What are you trying to do that isn't working?

miraclx avatar Sep 08 '23 14:09 miraclx

@miraclx

docker run --rm -it --entrypoint bash --name freyrcli -v $PWD:/data -v ./conf.json:/freyr/conf.json freyrcli/freyrjs-git:pr-214 -c "freyr apple_music:track:157624199"
266641497-6d6b866e-8f15-4851-83e2-0b0486a2759e

as you can see, Zero sources found.

but indeed, we can get result from youtube music

image

How can I download it?

wisetc avatar Sep 08 '23 14:09 wisetc

I'll take a look. Thanks.

miraclx avatar Sep 08 '23 14:09 miraclx

Top result is not included in result.

    TITLE_TEXT: ['title', 'runs', 0, 'text'],
    HEADER_TITLE_TEXT: ['header', 'title', 'runs', 0, 'text'],

maybe "Top result" always using a header

image

And I think that language settings is not related to this issue as mentioned above. I'm wrong.

wisetc avatar Sep 09 '23 08:09 wisetc

It seems that stripText will remove characters when calling StripChar.RSspecChar.

StripChar RSspecCharC' 1 q好 1d)

I don't think need to be striped.

maybe it works well when dealing with english songs, thanks for your work.

I'm just reporting this case.

wisetc avatar Sep 10 '23 07:09 wisetc

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

miraclx avatar Sep 10 '23 07:09 miraclx

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

@miraclx Track name.

for example: 忙與盲

thank you.

wisetc avatar Sep 10 '23 07:09 wisetc

non-Latin support for source feed lookups implemented in #574. Thanks for raising this.

miraclx avatar Sep 12 '23 00:09 miraclx

Just leaving a note here: The issue left here (may) be tied to the issue in https://github.com/miraclx/freyr-js/issues/576, and could be resolved by a single fix that merges track results in all sections from the YouTube Music search.

miraclx avatar Jan 01 '24 22:01 miraclx