freyr-js icon indicating copy to clipboard operation
freyr-js copied to clipboard

Option to skip the conversion step

Open ghost opened this issue 3 years ago • 5 comments

Converting a lossy file to another lossy format is a bad practice, the audio quality reduces 2 times (YouTube converts the upload on their side, and freyr converts it again), 3 times if the uploader sent a lossy audio too.

Sure, converting to AAC 320kbps is probably ok for YouTube's audio quality, but then you are creating bigger files for no reason. One of the songs I used to test it was 3.94 MB when downloaded, and 9.48 MB after conversion. Trying to reduce the bitrate to match the source size would be gambling with the audio quality too, since the same bitrate with different formats gives different results; a 128 kbps opus has higher quality than a 128 kbps aac.

Could you add an option to keep the original file, probably opus, and do everything else (tagging, organizing, etc...)?

ghost avatar Mar 20 '22 04:03 ghost

@Rubecks, yeah, we can probably do this. I'll have to do some research into which tools are available for embedding metadata of different audio formats. I think, so far, Mutagen – https://github.com/quodlibet/mutagen should suffice for as many formats as freyr needs. But since that's written in Python, we need to get #21 merged to aid bridging node and python.

miraclx avatar Mar 22 '22 13:03 miraclx

Yes indeed, this feature would be more than nice.

ocococococ avatar Jan 15 '23 10:01 ocococococ

Hi! I'm a new user, and notice something odd in the conversion process. The download file is 3.36 MB and the total output size is 2.15 GB. I'm not a 100% sure if related to the conversion process but is definitely worth of reviewing.

This is the command I used:

freyr get -b 256 https://open.spotify.com/track/5r5cp9IpziiIsR6b93vcnQ?si=295f54a7150349c2

Larox avatar Feb 23 '24 04:02 Larox

Ignore my comment, right after I came across https://github.com/miraclx/freyr-js/issues/625. It was related to atomicParsley. Bumping the version that solved the issue.

Hi! I'm a new user, and notice something odd in the conversion process. The download file is 3.36 MB and the total output size is 2.15 GB. I'm not a 100% sure if related to the conversion process but is definitely worth of reviewing.

This is the command I used:

freyr get -b 256 https://open.spotify.com/track/5r5cp9IpziiIsR6b93vcnQ?si=295f54a7150349c2

Larox avatar Feb 23 '24 05:02 Larox