Fix open mode, so it works

Open Brailliac opened this issue 6 years ago • 3 comments

Previously, the configuration file was being opened in bytes mode:

open(file, 'rb')`

This was wrong, it caused the script to crash, and throw related errors - for example:

TypeError: startswith first arg must be bytes or a tuple of bytes, not str

It is now read as a string, and the script works correctly.

Mar 10 '19 15:03 Brailliac

Coverage remained the same at 94.266% when pulling 23afabbd0b2325d18b35dbfcd2719c1967e2178a on Brailliac:master into 5c1954b35f409a6977265467e97f0baf60ed4718 on miracle2k:master.

Mar 10 '19 15:03 coveralls

Can someone please merge this PR as this fixes the issue mentioned above! @miracle2k ?

Sep 13 '21 20:09 sidgrover21

Can someone please merge this PR as this fixes the issue mentioned above! @miracle2k ?

May 28 '22 09:05 shumidub