mirdata icon indicating copy to clipboard operation
mirdata copied to clipboard

Adding the latest version of compmusic_otmm_makam

Open sertansenturk opened this issue 3 years ago • 0 comments

Hello mirdata people!

As we discussed aeons ago, compmusic_otmm_makam has a fix version that was not available when @genisplaja was implementing the original loader.

It was added to Zenodo (link) later, and it would be nice to have the latest version available in mirdata. I believe it is a small task, and I am happy to make the change myself.

To the best of my understanding, all I need to do is to follow the guideline in contributing.html#datasets-with-multiple-versions:

As the acceptance criteria, I could:

  • Add/update the unittests
  • Run (ad-hoc?) integration tests ensuring either version is downloaded appropriately.

Please let me know your thoughts, if I need to show extra care on some bits & bobs, and please do not hesitate to point out any concerns.

P.S: pinging @nkundiushuti, @genisplaja, @rabitt for visibility

sertansenturk avatar Jul 25 '22 15:07 sertansenturk