mirdata icon indicating copy to clipboard operation
mirdata copied to clipboard

[WIP] second version GiantSteps key

Open PRamoneda opened this issue 4 years ago • 4 comments

#307

PRamoneda avatar Nov 02 '20 15:11 PRamoneda

Codecov Report

Merging #315 (c37eeb8) into master (82c024c) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   99.00%   98.97%   -0.04%     
==========================================
  Files          26       25       -1     
  Lines        2718     2637      -81     
==========================================
- Hits         2691     2610      -81     
  Misses         27       27              

codecov[bot] avatar Nov 02 '20 15:11 codecov[bot]

I see this PR has been approved already, @PRamoneda what are we missing in this loader to be able to merge? (besides solving the conflicts)

magdalenafuentes avatar Jan 19 '21 11:01 magdalenafuentes

I have found some errors in Giantsteps Key and I have to speak with Angel faraldo

PRamoneda avatar Jan 19 '21 11:01 PRamoneda

Hi! We have to fix some things in the dataset and we are going to a new version. Then this PR is stopped until that!

PRamoneda avatar Feb 25 '21 10:02 PRamoneda

@magdalenafuentes @genisplaja you can close this thread. We are not going to do a new version

PRamoneda avatar Nov 02 '23 14:11 PRamoneda

Closing the PR as per @PRamoneda's comment.

guillemcortes avatar Nov 02 '23 17:11 guillemcortes