harvestman icon indicating copy to clipboard operation
harvestman copied to clipboard

Published 20 hours ago • verified publisher icon mion

remember the URI might be a good idea

Open jzhang533 opened this issue 11 years ago • 1 comments

remember the URI of the url processing might be a good idea.

jzhang533 avatar Sep 03 '13 05:09 jzhang533

Cool, thanks @jzhang533 ! But for some reason the test breaks* with:

TypeError: can't convert URI::Generic into String

No big deal though, I think it's just a matter of adding open-uri as a development dependency. Not that I think anyone is using the gem for anything serious after explicitly being told not to :laughing:, but maybe we could make it backward compatible with something like Harvestman.current_uri (and also leads to a nicer API)? Same thing for the other instace variables like @document. Ideas? If not I'll just merge it anyway!

[*] Actually it was already 'broken' because it tests for a missing feature I wanted to add.

mion avatar Sep 04 '13 05:09 mion