Dont crash on worker threads that have no PID, when reporting on stopped workers.
We are seeing errors, and subsequent restart loops for missing workers. Instead of recreating the missing workers, we crash on the missing PID when trying to emit a warning.
Changes
Please describe the essence of this PR in a few sentences. Mention any breaking changes or required configuration steps.
Issue link
You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.
Please add the link to the issue after "Closes".
Closes ...
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
- [ ] All the commits in this PR are properly PGP-signed and verified.
- [ ] This PR only contains functionality relevant to the issue.
- [ ] I have written unit tests for the changes or fixes I made.
- [ ] I have checked the documentation and made changes where necessary.
- [ ] I have performed a self-review of my code and refactored it to the best of my abilities.
- [ ] Tickets have been created for newly discovered issues.
- [ ] For any non-trivial functionality, I have added integration and/or end-to-end tests.
- [ ] I have informed others of any required
.envchanges files if required and changed the.env-distaccordingly. - [ ] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/developer-documentation/contributor/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/developer-documentation/contributor/templates folder into your comment.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
PR can't be merged because it doesn't pass pre-commit. It is recommended to install the pre-commit hook in your git repositroy so this doesn't happen again with future PRs, see the developer documentation at https://docs.openkat.nl/developer-documentation/contributor/guidelines/development.html#pre-commit.
We also made changes to the CLA bot which unfortunately means that it doesn't remember who signed the CLA in the past, so you need sign it again.