nl-kat-coordination icon indicating copy to clipboard operation
nl-kat-coordination copied to clipboard

Update kat_finding_types.json, add more in dept details

Open underdarknl opened this issue 1 year ago • 1 comments

Changes

I've added a bunch of details, and made an attempt at closing https://github.com/minvws/nl-kat-coordination/issues/4278 which was using the wrong language.

Issue link

Closes https://github.com/minvws/nl-kat-coordination/issues/4278

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.

QA notes

KATFindings should be more descriptive in general, and should also be mode detailed. To get the new details, the various KATFindingTypes need their jobs to be re-ran.


Code Checklist

  • [ ] All the commits in this PR are properly PGP-signed and verified.
  • [ ] This PR only contains functionality relevant to the issue.
  • [ ] I have written unit tests for the changes or fixes I made.
  • [ ] I have checked the documentation and made changes where necessary.
  • [ ] I have performed a self-review of my code and refactored it to the best of my abilities.
  • [ ] Tickets have been created for newly discovered issues.
  • [ ] For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • [ ] I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • [ ] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

underdarknl avatar Apr 10 '25 20:04 underdarknl