Styling changes to meet the design
According to @madelondohmen these changes are needed.
Changes
- Make headers, descriptions and "showing x of y items" the same size on every page
- Make the position of filters and "showing x of y items" the same on (almost) every page
- Update the description on the Reports overview page
- Update the titles of the Members and Settings page
- Move a lot of buttons to the top right of the page (with a "fifty-fifty" class)
- Delete the onboarding DNS Report, since we're now using recipes/schedules (and we're using the normal DNS Report)
- Delete "OOI Report" since that one isn't used anymore
- Add translations to the severity table
Demo
QA notes
Please walk through all pages to see if everything looks okay and the same style. Whitespaces will be fixes with CSS later, so don't look at those.
Code Checklist
- [x] All the commits in this PR are properly PGP-signed and verified.
- [x] This PR only contains functionality relevant to the issue.
- [ ] I have written unit tests for the changes or fixes I made.
- [x] I have checked the documentation and made changes where necessary.
- [x] I have performed a self-review of my code and refactored it to the best of my abilities.
- [ ] Tickets have been created for newly discovered issues.
- [ ] For any non-trivial functionality, I have added integration and/or end-to-end tests.
- [ ] I have informed others of any required
.envchanges files if required and changed the.env-distaccordingly. - [ ] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.
There are some more changes that are needed to make the UI meet the designs. @RomijnHumanoids and I will fix these in this branch/PR.
nice work!
Checklist for QA:
- [x] I have checked out this branch, and successfully ran a fresh
make reset. - [x] I confirmed that there are no unintended functional regressions in this branch:
- [x] I have managed to pass the onboarding flow
- [x] Objects and Findings are created properly
- [x] Tasks are created and completed properly
- [x] I confirmed that the PR's advertised
featureorhotfixworks as intended. - [x] I checked the logs for errors and/or warnings and made issues where necessary
What works:
Seems to work. Checked the code to look for other more obscure places where some bugs could occur, but didn't observe anything obvious.
What doesn't work:
n/a
Bug or feature?:
n/a
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code