nl-kat-coordination icon indicating copy to clipboard operation
nl-kat-coordination copied to clipboard

Use `apt-get` instead of `apt` in scripts

Open originalsouth opened this issue 9 months ago • 2 comments

Describe the bug Use apt-get instead of apt in scripts to prevent this warning:

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
  • and interaction with an unstable interface.

To Reproduce Steps to reproduce the behavior:

  1. make kat

Expected behavior No warning and a proper install.

Screenshots image

OpenKAT version main (fc7a5878cacf49ba442dee83df8a712e36fec352)

Additional context https://askubuntu.com/questions/990823/apt-gives-unstable-cli-interface-warning

originalsouth avatar May 07 '24 06:05 originalsouth

If we don't specifically use apt output in our scripts, I don't see any harm in the warnings and using apt as such. But either way is fine

ammar92 avatar May 07 '24 07:05 ammar92

Apt is not supposed to be used in scripts, so we should use apt-get. I think it might also be a good idea to add something like https://github.com/hadolint/hadolint to pre-commit to make sure we keep rid of these and other issues.

dekkers avatar May 07 '24 12:05 dekkers