More Scheduler Error handling from Rocky with more task details
Changes
- When scheduler client is offline, throw a ConnectionError and catch it to show message in rocky.
- Add more task details for when task fetching fails/success, or (re)scheduling task fails, or get task failures. (plugin + OOI)
Issue link
https://github.com/minvws/nl-kat-coordination/issues/1955
Closes https://github.com/minvws/nl-kat-coordination/issues/1955
Proof
Task detail when scheduling is successful
Task que is full + task details in error message:
ConnectionError threw whole rocky:
Task page:
Finding detail page:
OOI detail page:
Plugin detail Boefje
Plugin detail Normalizer:
Health page itself:
Code Checklist
- [x] All the commits in this PR are properly PGP-signed and verified;
- [x] This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
- [x] I have written unit tests for the changes or fixes I made.
- [x] For any non-trivial functionality, I have added integration and/or end-to-end tests.
- [x] I have performed a self-review of my code and refactored it to the best of my abilities.
Communication
- [x] I have informed others of any required
.envchanges files if required and changed the.env-distaccordingly. - [x] I have made corresponding changes to the documentation, if necessary.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
- [x] I have checked out this branch, and successfully ran a fresh
make reset. - [x] I confirmed that there are no unintended functional regressions in this branch:
- [x] I have managed to pass the onboarding flow
- [x] Objects and Findings are created properly
- [x] Tasks are created and completed properly
- [x] I confirmed that the PR's advertised
featureorhotfixworks as intended.
What works:
Error message is shown on the Tasks, Health checks, when opening a finding object, and on the 'See Details' page in the Katalogus. When enabling the scheduler again the error message disappears again.
What doesn't work:
n/a
Bug or feature?:
n/a
Blocked by https://github.com/minvws/nl-kat-coordination/issues/2598
During QA the following issues were identified:
- [ ] DnsRecords boefje details page in Katalogus misses some data. A similar thing is happening for Dnssec and nmap TCP boefjes.
- [ ] Normalizer template file removed from PR, which prevents various detail pages from loading.
DnsRecords boefje details page in this branch:
On main:
Template file removed from PR
From QA perspective it looks good now. The pages that were not properly loading in the katalogus now work again. Can be merged after Review has approved the changes.
From QA perspective it looks good now. The pages that were not properly loading in the katalogus now work again. Can be merged after Review has approved the changes.
One little thing I am fixing now is that the normalizer detail page is not showing the task list, but this I am fixing now, thanks!
