nl-kat-coordination
nl-kat-coordination copied to clipboard
minvws
First official release of OpenKAT Ansible installation playbook.
Changes
First official release of OpenKAT Ansible installation playbook.
Issue link
Proof
Screenshot of admin interface after running the playbook?
Code Checklist
Communication
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.
@kwoot nice! As you can see our pre-commit is complaining about some trailing spaces. In the meantime we will review this.
We linten onze playbooks over het algemeen met ansible-lint en de volgende config... dus als je de mogelijke meldingen van ansible-lint meteen kan verwerken, dan zou dit github linter 'm ook meteen moeten goedkeuren:
#warn_list: # or 'skip_list' to silence them completely skip_list:
- '204' # Lines should be no longer than 160 chars
- experimental
- fqcn-builtins
- fqcn
- name
- template-instead-of-copy
- var-naming[no-role-prefix] warn_list:
- no-handler
- ignore-errors offline: true
Bij voorkeur ook door steampunk spotter halen en fully-qualified module namen gebruiken
Seems Jan is doing stuff surrounding this PR. Let's reopen to see what happens.
We have decided to Not include any Ansible scripts in our Repository, but would like to and will actively link to contributed We don't have the internal resources to keep these scripts up to date, and while Ansible will be useful, it most likely wont be a ready to go script that works for actual production setups. This leads us to think people will most likely fork a given script and maintain it themselves in a separate repos, forking a smaller repos instead of the whole OpenKAT Repos makes sense, and allows us to link to more than one option.
Thank you so much for letting me know. It only took you 261 days to come to that conclusion.