ember-can icon indicating copy to clipboard operation
ember-can copied to clipboard

Published 20 hours ago • verified publisher icon minutebase

Install TypeScript

Open charlesfries opened this issue 3 years ago • 20 comments

  • Install TypeScript
  • Install DefinitelyTyped packages from Ember addon blueprint
  • Install @types/ember-data__model
  • Configure eslint for TS
  • Type AbilitiesService

charlesfries avatar Aug 07 '21 18:08 charlesfries

@minutebase @rlivsey Any interest in this?

charlesfries avatar Aug 12 '21 17:08 charlesfries

I've started adding type definitions for ember-can in our codebase as well.

It would be great to have types for this lib indeed 🤗

ping @Exelord

bartocc avatar Oct 21 '21 08:10 bartocc

I know, need that as well :) Ember-can is awaiting a major upgrade soon.

Exelord avatar Oct 21 '21 08:10 Exelord

I know, need that as well :) Ember-can is awaiting a major upgrade soon.

is this upgrade already started, or is it about to?

And in parallel, do you want more PRs with type definitions like this one?

bartocc avatar Oct 21 '21 13:10 bartocc

It's happening :) some changes just landed. TS will be welcome for upcoming v5

Exelord avatar Nov 26 '21 16:11 Exelord

@Exelord Is it still happening? 😋
I am slowly but surely converting our Ember app to TS and this addon is one of the few that doesn't come with types yet.

guidojw avatar Jan 05 '23 14:01 guidojw

Unfortunately I don't have enough time to work on it anymore :/ so the progres on next upgrade is on hold.

Exelord avatar Jan 06 '23 17:01 Exelord

@Exelord Is there anything we could help with to either merge this PR or move the V5 forward? 🙏

esbanarango avatar Jul 21 '23 23:07 esbanarango

Hey @esbanarango,

As mentioned, currently I do not have time to maintain this package. I am really sorry for that. I would recommend maintaining own fork with changes that are needed for your project taking into account how small this package is.

Exelord avatar Jul 22 '23 20:07 Exelord

@Exelord are you able to hand over maintenance to others who do have the time? Completely understood that you have other time constraints on your end, yet there's still interest in having a shared add-on that the community uses for this ...

acorncom avatar Jul 24 '23 17:07 acorncom

Hi @acorncom,

I have the rights to do it, but I am not the owner of this addon.

@rlivsey would you like to choose a new maintainer or pass ownership to someone?

Exelord avatar Jul 24 '23 17:07 Exelord

@Exelord @rlivsey might I suggest transferring this to adopted-ember-addons?

RobbieTheWagner avatar Jan 25 '24 15:01 RobbieTheWagner

@rlivsey would be nice to transfer this addon to adopted-ember-addons or to get a new maintainer, so that the addon can be migrate to TS and addon v2

mkszepp avatar Mar 10 '24 06:03 mkszepp

I cannot move the repo, but as the author is not responding, I will grant maintenance permission.

Who would like to take it over?

Exelord avatar Mar 14 '24 22:03 Exelord

@Exelord I can help

esbanarango avatar Mar 14 '24 22:03 esbanarango

I'm also willing to help. Getting this in would be great 😄

RobbieTheWagner avatar Mar 27 '24 00:03 RobbieTheWagner

Done. Please sync with each other on next steps :) @RobbieTheWagner @esbanarango

Exelord avatar Mar 27 '24 16:03 Exelord

Thanks @Exelord! @esbanarango do you have the cycles to take a look at getting this ready to merge? I won't have availability for probably a few weeks.

RobbieTheWagner avatar Mar 29 '24 14:03 RobbieTheWagner

@RobbieTheWagner Yeah, I'll take a look! @charlesfries Let me know once this is ready 🤝

esbanarango avatar Mar 29 '24 20:03 esbanarango

@esbanarango should be good now

charlesfries avatar Mar 29 '24 22:03 charlesfries