mintlayer-core icon indicating copy to clipboard operation
mintlayer-core copied to clipboard

Wallet remaining tasks

Open TheQuantumPhysicist opened this issue 2 years ago • 0 comments

  • [x] Sign a message to prove ownership of pool (#1521)
  • [x] submit transaction command does not add the tx to the wallet
  • [x] connect from wallet CLI to a running RPC wallet?
  • [x] Change the function staking-list-created-block-ids to show the pool that created the block, not just the block ids.
  • [x] Fix wallet GUI addresses not showing up before importing. To reproduce the problem, generate a mnemonic (using address-generator, maybe), then create an address, send coins to it (address with index 0), then import the mnemonic in the GUI. Once the scan is done, you'll see that new addresses will start from index 1, not 0, and that address will never show up in the GUI. The correct behavior is: When scanning, when a transaction is found, all addresses with indexes 0 to that address should be imported and shown. It's an open question whether the CLI has the same behavior.
  • [x] The wallet_conflict.py functional test issue on windows failing spuriously
  • [x] Create sweep functions for addresses (or multiple thereof) to allow automatically calculating the fee from the total amount in the address.
  • [x] Fix staking-list-created-block-ids when decommission key is a cold key, it doesn't work.
  • [x] When running the wallet-cli in git-bash on Windows, the prompt doesn't show correctly, like the wallet> at the beginning of the line. We have to understand what's going on.
  • [x] Watch addresses (add the possibility to add an address to the wallet that the user doesn't own, only to see their balance)
  • [x] Add multi-sig support
  • [x] Improve list pool IDs functionality to include both pool pledge and pool delegations balance
  • [x] Add a function in controller to sign (or partially sign) an arbitrary transaction
  • [ ] Add the possibility to create a transaction using a specific set of utxos (equivalent to coin-control in bitcoin core)
  • [ ] Add button to decommission the pool with BIG confirmation about the consequences + tx summary.
  • [ ] Is it possible to add confirmation prompts to wallet CLI? Like before submitting a transaction, ask the user to confirm. We want to do this for all critical operations, like sending transactions, decommissioning, submitting transactions, etc.
  • [ ] investigate wallet panic after node db file deleted
  • [ ] investigate wallet printing broken new lines after panic
  • [x] Find a mechanism to be able to run a cold wallet (without internet connection)
  • [ ] See if we can implement fuzzy search. So, if we start a command with /, then anything typed will become a fuzzy search over all commands (and possible their help)
  • [ ] when no wallet is opened only show wallet create/open commands
  • [ ] remove syncing logs, and also is address used in transaction column when using a cold wallet
  • [ ] exclude pools and delegations balances counting in address balance in API Server?
  • [x] Embed a CLI that maps to RPC calls to both the node and the wallet, just like bitcoin core's CLI in the GUI.
  • [ ] try to unify vrf chain with the other key chain, so that we don't have different behaviours like the topup bug in loading of the vrf keychain

TheQuantumPhysicist avatar Oct 23 '23 21:10 TheQuantumPhysicist